[PATCH] D60261: Change semantics of fadd/fmul vector reductions.

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM with the FIXME adjusted.



================
Comment at: include/llvm/CodeGen/BasicTTIImpl.h:1266
+          /*IsPairwiseForm=*/false); // FIXME: This should be set to
+                                     // 'FMF.allowReassoc()'
     case Intrinsic::experimental_vector_reduce_smax:
----------------
Regardless of IsPairwiseForm, this will compute an unordered reduction cost, just for two different reduction strategies. Just passing FMF.allowReassoc() here wouldn't be meaningful. We'd need a separate flag to indicate ordered reductions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60261/new/

https://reviews.llvm.org/D60261