[PATCH] D60261: Change semantics of fadd/fmul vector reductions.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: test/CodeGen/Generic/expand-experimental-reductions.ll:113
 entry:
-  %r = call fast float @llvm.experimental.vector.reduce.fadd.f32.v4f32(float %accum, <4 x float> %vec)
+  %r = call fast float @llvm.experimental.vector.reduce.v2.fadd.f32.v4f32(float %accum, <4 x float> %vec)
   ret float %r
----------------
nikic wrote:
> The expansion above looks wrong per new semantics -- shouldn't there be a use `%accum` in there? Probably the IR level expansion code needs to be adjusted.
Good spot! I've fixed this now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60261/new/

https://reviews.llvm.org/D60261