[PATCH] D62607: LoopDistribute/LAA: Respect convergent

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 17:00:30 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1877
     LLVM_DEBUG(dbgs() << "LAA: Found a read-only loop!\n");
     CanVecMem = true;
     return;
----------------
Meinersbur wrote:
> [serious] Is a `if (!CanVecMem) return;` missing before this? This would switch it back on again independently of whether `HasComplexMemInst` is set.
This made me find 2 broken things not covered by tests (D63035)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62607/new/

https://reviews.llvm.org/D62607





More information about the llvm-commits mailing list