[PATCH] D62877: [WebAssembly] Implement tail calls and unify tablegen call classes
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 7 04:05:27 PDT 2019
aheejin added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:790
+ InTys.clear();
+ InTys.push_back(MVT::Other);
+ InTys.push_back(MVT::Glue);
----------------
- Sorry, but why should we clear `InTys` here? I understand that we don't need output types, but should input types different from normal calls?
- `InTys.push_back(MVT::Other);` is common for both `if` and `else`, so we can hoist it (If we don't need to clear `InTys`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62877/new/
https://reviews.llvm.org/D62877
More information about the llvm-commits
mailing list