[PATCH] D62877: [WebAssembly] Implement tail calls and unify tablegen call classes

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 22:52:59 PDT 2019


dschuff added inline comments.


================
Comment at: llvm/docs/CodeGenerator.rst:2107
 
+On WebAssembly, tail calls are lowered to ``return_call`` and
+``return_call_indirect`` instructions whenever the 'tail-call' target attribute
----------------
Shouldn't we have the same restrictions on PIC code?
Also, while it seems like va_arg and byval should work, if we're going to promise to optimize those too, we should have some tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62877/new/

https://reviews.llvm.org/D62877





More information about the llvm-commits mailing list