[PATCH] D62964: [llvm-objdump] Include dynamic zero-sized and non-function symbols in disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D62964#1533587 <https://reviews.llvm.org/D62964#1533587>, @MaskRay wrote:

> The test doesn't have a dynamic symbole table (.dynsym) so the source change seems irrelevant.


@MaskRay, the test DOES have a dynamic symbol table. Line 61 in the updated test starts the DynamicSymbols list, which causes one to be implicitly generated.

I think the code change is mostly just to bring things into line with static symbol dumping, but I could see an argument for deleting the if statement entirely. In that case, I'd just confirm against GNU objdump behaviour to see if it really matters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964