[PATCH] D62964: [llvm-objdump] Include dynamic zero-sized and non-function symbols in disassembly

Thu Jun 6 21:27:19 PDT 2019

MaskRay added a comment.

The test doesn't have a dynamic symbole table (.dynsym) so the source change seems irrelevant.
I think we have the current output without the source change.

See not_func is misaligned, so something goes wrong.

  0000000000001001 both_dyn:
      1001: 90                            nop
      1002: 90                            nop

  0000000000001003 not_func:
      1003:        90                              .

STT_SECTION exists primarily for relocations are they normally have `STB_LOCAL` binding.
None of ld.bfd/gold/lld places `STB_LOCAL` symbols in `.dynsym` (I am less confident with the statement regarding ld.bfd) so the updated test may not be used in practice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964