[PATCH] D62745: Factor out SelectionDAG's switch analysis and lowering into a separate component

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D62745#1531532 <https://reviews.llvm.org/D62745#1531532>, @qcolombet wrote:

> Hi Amara,
>
> LGTM.
>
> The only comment I have is regarding the new namespace `switchop`: should we have one, should we have something camel case?
>  I don't feel strongly about it, just that it feels unusual compared to no namespace or existing camel cases ones `ISD`, `RegAlloc`, etc. We have non-camel case ones too, thus up to you.
>
> Cheers,
> -Quentin


Thanks. I had to introduce one to avoid a naming collision with another definition of JumpTable somewhere else in llvm, and I think in general these utilities are so closely related that a namespace is probably useful. I'm open to renaming it though. what about something like SwitchCG?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62745/new/

https://reviews.llvm.org/D62745