[PATCH] D62745: Factor out SelectionDAG's switch analysis and lowering into a separate component
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 5 13:28:16 PDT 2019
qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
Hi Amara,
LGTM.
The only comment I have is regarding the new namespace `switchop`: should we have one, should we have something camel case?
I don't feel strongly about it, just that it feels unusual compared to no namespace or existing camel cases ones `ISD`, `RegAlloc`, etc. We have non-camel case ones too, thus up to you.
Cheers,
-Quentin
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62745/new/
https://reviews.llvm.org/D62745
More information about the llvm-commits
mailing list