[PATCH] D62542: [WebAssembly] Make Emscripten-specific behavior specific to the Emscripten target

Wed Jun 5 11:19:24 PDT 2019

sunfish added a comment.

In D62542#1529441 <https://reviews.llvm.org/D62542#1529441>, @sbc100 wrote:

> I was hoping you could have the linker default to exporting NO_STRIP symbols?   If you don't like that idea then perhaps would have the "export NO_STRIP symbols" behaviour be emscripten-only in the linker and have it driven by the same signal we end up using for `-shared/-pie`.

It doesn't have that meaning in ELF targets, for example.

> Do do you think we will end up wanted a separate EXPORTED flag for symbol in any case?  For example with WASI, will we will presumably want some way to export symbols based on source attributes?

I don't know yet. There still are some questions about whether we want to have a separate layer of visibility between ESM's and C++ libraries.

> Should we add `wasm-export-name` attribute like we have for `wasm-import-name`?

Yes, I expect we'll want this, though I myself don't have anything that urgently needs it.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62542/new/

https://reviews.llvm.org/D62542