[PATCH] D62542: [WebAssembly] Make Emscripten-specific behavior specific to the Emscripten target

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 09:25:50 PDT 2019


sbc100 added a comment.

I was hoping you could have the linker default to exporting NO_STRIP symbols?   If you don't like that idea then perhaps would have the "export NO_STRIP symbols" behaviour be emscripten-only in the linker and have it driven by the same signal we end up using for `-shared/-pie`.

So then we can just rename the existing EXPORTED to NO_STRIP to avoid adding another flag here?

Do do you think we will end up wanted a separate EXPORTED flag for symbol in any case?  For example with WASI, will we will presumably want some way to export symbols based on source attributes?    Should we add `wasm-export-name` attribute like we have for `wasm-import-name`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62542/new/

https://reviews.llvm.org/D62542





More information about the llvm-commits mailing list