[PATCH] D62511: Sanitize llvm-extract -help output

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 00:21:57 PDT 2019


serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/tools/llvm-extract/llvm-extract.cpp:43
+                                          cl::value_desc("filename"),
+                                          cl::cat(ExtractCat));
 
----------------
jhenderson wrote:
> Do you need the category here on a positional argument?
Definitively not!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62511/new/

https://reviews.llvm.org/D62511





More information about the llvm-commits mailing list