[PATCH] D62511: Sanitize llvm-extract -help output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 04:04:36 PDT 2019


jhenderson added a comment.

I'm not familiar at all with llvm-extract, but what you've done looks reasonable, barring one comment. Maybe worth seeing if there are others who have used/developed this tool to get a bit more confirmation.



================
Comment at: llvm/tools/llvm-extract/llvm-extract.cpp:43
+                                          cl::value_desc("filename"),
+                                          cl::cat(ExtractCat));
 
----------------
Do you need the category here on a positional argument?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62511/new/

https://reviews.llvm.org/D62511





More information about the llvm-commits mailing list