[PATCH] D62838: [Object] add isExecutableObject member function

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 09:31:31 PDT 2019


sbc100 added inline comments.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1540
 
+bool WasmObjectFile::isExecutableObject() const {
+  llvm_unreachable("Not implemented yet!");
----------------
jhenderson wrote:
> Could this just be `!isRelocatableObject() && !isSharedObject()`? I don't know anything about wasm though, so this might not make sense.
Yes that sounds correct to me. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62838/new/

https://reviews.llvm.org/D62838





More information about the llvm-commits mailing list