[PATCH] D62838: [Object] add isExecutableObject member function

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Hi @abrachet - you forgot to include context with this diff, so it's somewhat harder to review as is. Please update with context.

What is the purpose of this function? Do you have a use-case for it yet?

You should also add some unit tests for this. I don't think it would be too hard, but you might need to create some new unit test files.



================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:25
 
+// Flags for the headers f_flag field
+enum HeaderFlags {
----------------
Missing trailing full stop.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1540
 
+bool WasmObjectFile::isExecutableObject() const {
+  llvm_unreachable("Not implemented yet!");
----------------
Could this just be `!isRelocatableObject() && !isSharedObject()`? I don't know anything about wasm though, so this might not make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62838/new/

https://reviews.llvm.org/D62838