[PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 04:19:34 PDT 2019


grimar added a comment.

In D62846#1528999 <https://reviews.llvm.org/D62846#1528999>, @jhenderson wrote:

> LGTM, although I note that the symbols are no longer STT_FUNC. Is that intentional? Does it matter (probably not)?


I just tried to reduce the YAML description. The type does not seem to be important, so I removed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62846/new/

https://reviews.llvm.org/D62846





More information about the llvm-commits mailing list