[PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 04:15:26 PDT 2019

Previous message: [PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases
Next message: [PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

jhenderson added a comment.

LGTM, although I note that the symbols are no longer STT_FUNC. Is that intentional? Does it matter (probably not)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62846/new/

https://reviews.llvm.org/D62846

Previous message: [PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases
Next message: [PATCH] D62846: [llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list