[PATCH] D62668: [ARM] First MVE instructions: scalar shifts.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/test/MC/ARM/mve-scalar-shift.s:2
+# RUN: not llvm-mc -triple=thumbv8.1m.main-none-eabi -mattr=+mve -show-encoding  < %s \
+# RUN:   | FileCheck --check-prefix=CHECK-NOFP %s
+# RUN: not llvm-mc -triple=thumbv8.1m.main-none-eabi -mattr=+mve.fp,+fp64 -show-encoding  < %s 2>%t \
----------------
If all of the instructions in this file are expected to be valid with and without FP, we can use the same check-prefix for both. We should also check the error output in the no-FP case.

We should probably also be checking that these instructions are all rejected when MVE is disabled, like you are already doing for disassembly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62668/new/

https://reviews.llvm.org/D62668