[PATCH] D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 1 09:23:49 PDT 2019
krytarowski added a comment.
> whereas others emit "is a directory
I don't know who is 'others' but NetBSD allows opening and reading directories as they would be files.
If there is requirement to reject reading of directories in llvm-objdump or underlying API, let us know and we will add extra check in the LLVM code using fstat(2) & S_ISDIR().
As @mgorny stated, this check might have no real purpose as reading directories will fail in one or another way virtually always and the tests check obvious behavior.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62773/new/
https://reviews.llvm.org/D62773
More information about the llvm-commits
mailing list