[PATCH] D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test

[Michał Górny via Phabricator via llvm-commits]

mgorny created this revision.
mgorny added reviewers: mtrent, pete, lhames, JDevlieghere, krytarowski.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.

Remove the test checking error message for 'is a directory'.  It does
not seem to serve any real purpose, and it relies on matching platform
error strings which are unpredictable and makes the test fragile.
Furthermore, it fails on NetBSD where read() works on directories,
and therefore does not return EISDIR at all.

Fixes r362141.


Repository:
  rL LLVM

https://reviews.llvm.org/D62773

Files:
  llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test


Index: llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
===================================================================
--- llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
+++ llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
@@ -15,8 +15,3 @@
 // RUN: llvm-objdump -m -d -g -dsym %p/../Inputs/libbogus11.a %p/../../dsymutil/Inputs/basic.macho.x86_64 2>&1 | FileCheck -check-prefix BAD_INPUT %s
 
 BAD_INPUT: is not a Mach-O or Universal file type.
-
-// RUN: not llvm-objdump -m -d -g -dsym %p/Inputs %p/Inputs/hello-macho-thin 2>&1 | FileCheck -check-prefix DIRECTORY %s
-
-// Windows will emit "Is a directory", whereas others emit "is a directory"
-DIRECTORY: {{[i|I]}}s a directory


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62773.202544.patch
Type: text/x-patch
Size: 733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190601/30202725/attachment.bin>