[PATCH] D62701: [PDB] Copy inlinee lines records into the PDB

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 11:08:59 PDT 2019

rnk added a comment.

In D62701#1525151 <https://reviews.llvm.org/D62701#1525151>, @aganea wrote:

> I've noticed btw that `obj2yaml/yaml2obj` doesn't preserve the `BinaryAnnotations` if `SectionData` values are skimmed out of the .yaml (to reduce size). There's also something missing for `S_FRAMEPROC` in that regard:
> F8993059: compare_inlinesite.png <https://reviews.llvm.org/F8993059>

Hm. Going forward, I kind of feel like we should move towards writing tests in assembly and port some of the YAML ones to assembly. I think if we structure the assembly right, it can be more readable and more compact than YAML. It follows how things were done for ELF lld testing. I have an intern who is working on making LLVM generate more human-readable codeview record assembly, which is basically what I'm hacking on here.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list