[PATCH] D62701: [PDB] Copy inlinee lines records into the PDB

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

I've noticed btw that `obj2yaml/yaml2obj` doesn't preserve the `BinaryAnnotations` if `SectionData` values are skimmed out of the .yaml (to reduce size). There's also something missing for `S_FRAMEPROC` in that regard:

F8993059: compare_inlinesite.png <https://reviews.llvm.org/F8993059>



================
Comment at: lld/test/COFF/pdb-inlinees-extrafiles.s:6
+
+# The assembly was hand written to model the following C code. As of this
+# writing, clang does not emit extra files for inlinees, so it had to be hand
----------------
Why not:
```
$ cl /Z7 /c /O2 t.c
$ obj2yaml t.obj >t.yaml
```
Which changes the test to:
```
# REQUIRES: x86
# RUN: yaml2obj %s -o=%t.obj
# RUN: lld-link -entry:main -nodefaultlib %t.obj -out:%t.exe -pdb:%t.pdb -debug
# RUN: llvm-pdbutil dump -il %t.pdb | FileCheck %s
```
I think it should be made clear/easy to re-generate the tests, if we want to change it, or if someone wants to duplicate it.



================
Comment at: lld/test/COFF/pdb-inlinees-extrafiles.s:24
+#   ++x;
+# #include "t1.inc"
+#   ++x;
----------------
t1.h


================
Comment at: lld/test/COFF/pdb-unknown-subsection.s:13
+# CHECK:        4 | S_COMPILE3 [size = 52]
+# CHECK:            machine = intel x86-x64, Ver = clang verison SENTINEL, language = c
+
----------------
/s/verison/version (and the same below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62701/new/

https://reviews.llvm.org/D62701