[PATCH] D62725: [ELF] Replace a dead test in getSymVA() with assert()
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 03:10:14 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362218: [ELF] Replace a dead test in getSymVA() with assert() (authored by MaskRay, committed by ).
CHANGES SINCE LAST ACTION
@@ -47,17 +47,11 @@
auto &D = cast<Defined>(Sym);
SectionBase *IS = D.Section;
- // According to the ELF spec reference to a local symbol from outside
- // the group are not allowed. Unfortunately .eh_frame breaks that rule
- // and must be treated specially. For now we just replace the symbol with
- // 0.
- if (IS == &InputSection::Discarded)
- return 0;
// This is an absolute symbol.
+ assert(IS != &InputSection::Discarded);
IS = IS->Repl;
uint64_t Offset = D.Value;
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 727 bytes
Desc: not available
More information about the llvm-commits