[PATCH] D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer

[Seiya Nuta via Phabricator via llvm-commits]

seiya updated this revision to Diff 202344.
seiya added a comment.

- Simplified various-symbols.s.
- Replaced `strlenOrMaxLen` (introduced by this patch) with `strnlen`.
- Replaced the hard-coded lengths of segment/section name with `sizeof()`.
- Renamed `updateDysymtab` to `updateDySymTab `.
- Replaced `copyStringWithPadding` (introduced by this patch) with `memset`-ing by zero and `memcpy`.
- Add `const` to a variable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62652/new/

https://reviews.llvm.org/D62652

Files:
  llvm/test/tools/llvm-objcopy/MachO/Inputs/various-symbols.s
  llvm/test/tools/llvm-objcopy/MachO/real-world-input-copy.test
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.h
  llvm/tools/llvm-objcopy/MachO/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62652.202344.patch
Type: text/x-patch
Size: 15849 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190531/24b187d9/attachment.bin>