[PATCH] D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/real-world-input-copy.test:13
+# RUN: llvm-objcopy %t.some-symbols.o %t.some-symbols.copy.o
+# RUN: cmp %t.some-symbols.o %t.some-symbols.copy.o
+
----------------
compnerd wrote:
> The test input seems oddly complicated for testing that.  It seems that anything that contains a `LC_DYNSYMTAB` which means anything with an externally visible symbol should be sufficient.  The BSS section would be emitted by any static.  Something like this seems much more concise which is better for testing the cases:
> 
> ```
> static int i;
> int f(void) { return i; }
> ```
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62652/new/

https://reviews.llvm.org/D62652