[PATCH] D62595: [AARCH64][ELF][llvm-readobj] Support for AArch64 .note.gnu.property
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 30 03:21:45 PDT 2019
grimar added inline comments.
Comment at: test/tools/llvm-readobj/aarch64-note-gnu-property.s:1
+// REQUIRES: aarch64-registered-target
+// RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu %s -o %t
> This line is not needed. llvm-readobj doesn't use any llvm/lib/Target/AArch64 code (I guess that is what aarch64-registered-target is about)
> Also consider moving the test under the `AArch64` directory since it is there?
I think this is for `llvm-mc` call below..
We can avoid it with using yaml instead, but perhaps it is not that really valuable.
CHANGES SINCE LAST ACTION
More information about the llvm-commits