[PATCH] D62595: [AARCH64][ELF][llvm-readobj] Support for AArch64 .note.gnu.property

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 03:17:12 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/aarch64-note-gnu-property.s:1
+// REQUIRES: aarch64-registered-target
+// RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu %s -o %t
----------------
This line is not needed. llvm-readobj doesn't use any llvm/lib/Target/AArch64 code (I guess that is what aarch64-registered-target is about)

Also consider moving the test under the `AArch64` directory since it is there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62595/new/

https://reviews.llvm.org/D62595





More information about the llvm-commits mailing list