[PATCH] D56274: [OPENMP][NVPTX]Fix incompatibility of __syncthreads with LLVM, NFC.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 29 12:37:46 PDT 2019
ABataev added a comment.
In D56274#1521780 <https://reviews.llvm.org/D56274#1521780>, @arsenm wrote:
> In D56274#1521772 <https://reviews.llvm.org/D56274#1521772>, @arsenm wrote:
> > In D56274#1521762 <https://reviews.llvm.org/D56274#1521762>, @grokos wrote:
> > > In D56274#1520909 <https://reviews.llvm.org/D56274#1520909>, @arsenm wrote:
> > >
> > > > D62581 <https://reviews.llvm.org/D62581>
> > >
> > >
> > > Thanks for this! Should we now revert this patch to use `syncthreads()` once again instead of the asm instruction?
> > Yes
> The asm also isn't necessarily a real workaround. Inline asm call sites need to be marked as convergent as well
I agree. Plus, we have the same problem with the named barriers. They also are represented as inline asm and also must be marked as convergent.
CHANGES SINCE LAST ACTION
More information about the llvm-commits