[PATCH] D62577: [ELF] Support Local Dynamic style TLSDESC for x86-64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 04:20:22 PDT 2019


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: ELF/Writer.cpp:1609
 
+  if (Config->EMachine == EM_X86_64) {
+    // _TLS_MODULE_BASE_ is defined in such a way that _TLS_MODULE_BASE_ at tpoff =
----------------
grimar wrote:
> i.e. how much reasonable this check is?
In GNU linkers, `_TLS_MODULE_BASE_` is defined on demand on i386/x86-64/arm/aarch64/s390. Many targets don't have an ABI for TLSDESC. If you feel we don't have to special case the TLSDESC targets that support TLSDESC, I can make this unconditional.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62577/new/

https://reviews.llvm.org/D62577





More information about the llvm-commits mailing list