[PATCH] D62577: [ELF] Support Local Dynamic style TLSDESC for x86-64

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputSection.cpp:590
   case EM_ARM:
   case EM_AARCH64:
     // Variant 1. The thread pointer points to a TCB with a fixed 2-word size,
----------------
I searched for `_TLS_MODULE_BASE_` in LLVM code and found it is mentioned, but only for AARCH64.
Should it be created for this target too?


================
Comment at: ELF/Writer.cpp:1609
 
+  if (Config->EMachine == EM_X86_64) {
+    // _TLS_MODULE_BASE_ is defined in such a way that _TLS_MODULE_BASE_ at tpoff =
----------------
i.e. how much reasonable this check is?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62577/new/

https://reviews.llvm.org/D62577