[PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added a comment.

@rengolin @hsaito Hm... I'm about to removing the private method `createMissedAnalysis` from `LoopVectorizationLegality.h` but since it was a method an had access to `TheLoop` and `Hints` class members, the pass name and Loop also must be passes to `reportVectorizationFailure` as parameters and instead of only additional parameter: `ORE`, the utility function should take three. The signature is the following:

  cpp
  /// Reports a vectorization illegality: print \p DebugMsg for debugging
  /// purposes along with the corresponding optimization remark.
  static void reportVectorizationFailure(const StringRef DebugMsg,
      const StringRef OREMsg, const StringRef ORETag, const char * PassName,
      OptimizationRemarkEmitter *ORE, Loop *Loop, Instruction *I = nullptr);

I think it doesn't look nice. But if you accepted this signature, I'll update the diff to using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62478/new/

https://reviews.llvm.org/D62478