[PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.

Pavel Samolysov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 11:21:13 PDT 2019


psamolysov added a comment.

@rengolin thank you for the comment, you are right, a private method also has an implicit parter this so the number of parameters will be the same.

@hsaito well, I will update the patch, but unfortunately we have no header for LoopVectorize.cpp so I'm thinking about moving the definition of the reportVectorizationFailure to LoopVectorize.cpp and add the external declaration to LoopVectorizationLegality.cpp but, as you have mentioned, in a different commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62478/new/

https://reviews.llvm.org/D62478





More information about the llvm-commits mailing list