[PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.

Pavel Samolysov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 20:04:00 PDT 2019

Previous message: [PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.
Next message: [PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

psamolysov added a comment.

I don't understand why having a function with a lot of arguments is better than a private method getting access to the class' members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62478/new/

https://reviews.llvm.org/D62478

Previous message: [PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.
Next message: [PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list