[PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 27 13:14:55 PDT 2019
rengolin added a comment.
In D62478#1518099 <https://reviews.llvm.org/D62478#1518099>, @psamolysov wrote:
> @rengolin It is because the function uses `OptimizationRemarkEmitter *ORE`, a member of the `LoopVectorizationLegality` class.
I see. Given the function has a lot of arguments already and it really isn't used elsewhere, I'd rather just add ORE to the args list.
Unless @hsaito or @fhahn think this could be used elsewhere in the vectorizer, then it shouldn't be in that class anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62478/new/
https://reviews.llvm.org/D62478
More information about the llvm-commits
mailing list