[PATCH] D59903: [NFC][FnAttrs] Stress tests for attribute deduction

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 11:37:53 PDT 2019


jdoerfert marked 3 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll:322
+;
+; long* negative_test_not_captured_but_returned_call_comparison against NULLa(long *a) {
+;   return not_captured_but_returned_1(a);
----------------
Function name will be fixed, below the same.


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_returned.ll:150
+
+; TEST the same SCC as in SCC test returning an integer value argument returning a pointer value argument
+;
----------------
Description will be improved.


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_returned.ll:311
+; CHECK: Function Attrs: noinline norecurse nounwind uwtable
+; CHECK: define linkonce_odr i32* @maybe_redefined_fn(i32* %r) [[NoInlineNoRecurseNoUnwindUwtable:#[0-9]*]]
+; FIXME: We should not derive norecurse for potentially redefined functions!
----------------
`NoInlineNoRecurseNoUnwindUwtable` will be removed (below as well)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59903/new/

https://reviews.llvm.org/D59903





More information about the llvm-commits mailing list