[PATCH] D62369: [ADT] Enable set_difference() to be used on StringSet

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/unittests/ADT/StringSetTest.cpp:33-42
+TEST_F(StringSetTest, SetDiffTest) {
+  StringSet<> SS1{"a", "b"};
+  StringSet<> SS2{"a"};
+
+  auto Diff = set_difference(SS1, SS2);
+  auto DiffVec = to_vector<1>(Diff.keys());
+
----------------
I'd still prefer this as two unit tests for the two new functions you added (& the test wouldn't use set_difference at all - unit tests being what they are, try to test things in isolation) - but I'll leave it up to you. No big deal (:


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62369/new/

https://reviews.llvm.org/D62369