[PATCH] D60640: AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:468
+  MachineRegisterInfo &MRI = MF->getRegInfo();
+  DebugLoc DL = I.getDebugLoc();
+
----------------
const &


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:496
+  assert(Size == 32);
+  // FIXME: Support 64-bit compares
+  MachineInstr *Select =
----------------
s/compares/select?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60640/new/

https://reviews.llvm.org/D60640