[PATCH] D62388: [FPEnv] PowerPC Vector Constrained FP Intrinsics Test

Fri May 24 12:45:11 PDT 2019

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In D62388#1516546 <https://reviews.llvm.org/D62388#1516546>, @kpn wrote:

> Drew is working with me here at SAS Institute, Inc.
>
> In D62388#1516530 <https://reviews.llvm.org/D62388#1516530>, @hfinkel wrote:
>
> > Just to clarify, do you currently expect all of these lowerings to be semantically correct, or only to mirror the regular lowering path right now?
>
>
> They should mirror the regular lowering path at least for the most part. Is there a case in this test where that produces semantically incorrect results?

No, but I certainly haven't looked through all 10k lines in detail ;) - I worry somewhat about the rounding modes and the lowerings that call libc, that call the runtime library, and that use instruction directly.

In any case, we can move forward with adding this now and then update as need be.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62388/new/

https://reviews.llvm.org/D62388