[PATCH] D62344: [AArch64] Preserve X8 for thunks ending in variadic musttail calls

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D62344#1514876 <https://reviews.llvm.org/D62344#1514876>, @efriedma wrote:

> The varargs argument list for a function normally can't contain an sret parameter; I guess musttail vararg lists are special.  Maybe worth calling out in the LangRef description of mustttail?  (I guess you could argue that sret is an ABI issue which is inherently target-specific, but it still seems a little surprising.)


There was half a sentence in langref about forwarding varargs, but it was really meant to be a stronger guarantee. I added another bullet there, feel free to take a look and suggest improvements.

> Otherwise LGTM

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62344/new/

https://reviews.llvm.org/D62344