[PATCH] D62344: [AArch64] Preserve X8 for thunks ending in variadic musttail calls

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 16:38:56 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

The varargs argument list for a function normally can't contain an sret parameter; I guess musttail vararg lists are special.  Maybe worth calling out in the LangRef description of mustttail?  (I guess you could argue that sret is an ABI issue which is inherently target-specific, but it still seems a little surprising.)

Otherwise LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62344/new/

https://reviews.llvm.org/D62344





More information about the llvm-commits mailing list