[PATCH] D62256: [llvm-readobj] Implement GNU-style output for dynamic table
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 22 09:05:21 PDT 2019
atanasyan marked an inline comment as done.
atanasyan added a comment.
In D62256#1512194 <https://reviews.llvm.org/D62256#1512194>, @MaskRay wrote:
> I think the header row is apparently misaligned. Not sure we want to misalign ourselves...
I do not emulate this misalignment. Header row aligned properly in both 32/64-bit cases.
> Regarding the extra parentheses, I am not sure if we really want to make llvm-readelf/llvm-readobj different just to become more readelf-like
As to me, the parentheses do not make sense. If everybody agree that we do not need to emulate GNU `readelf` formatting in all details, I will be happy to drop these parentheses.
================
Comment at: llvm/test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test:123
+# GNU-MIPS-NEXT: 0x000000007000002c (MIPS_INTERFACE_SIZE)0x10
+# GNU-MIPS-NEXT: 0x000000007000002d (MIPS_RLD_TEXT_RESOLVE_ADDR)0x8
+# GNU-MIPS-NEXT: 0x000000007000002e (MIPS_PERF_SUFFIX) 0x0
----------------
MaskRay wrote:
> `(MIPS_RLD_TEXT_RESOLVE_ADDR)0x8`
>
> This missing space separator definitely looks weird. What does GNU readelf do?
GNU readelf adds space between fields. I will fix that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62256/new/
https://reviews.llvm.org/D62256
More information about the llvm-commits
mailing list