[PATCH] D62256: [llvm-readobj] Implement GNU-style output for dynamic table

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Not looked at the implementation in detail yet, but to address @MaskRay's comment, we should definitely add the extra parentheses in llvm-readelf output. We could always add it in llvm-readobj too, but I'm less bothered by that. As close to byte-to-byte identical output as possible was requested for GNU style output by multiple individuals at the recent LLVM Binutils BoF and round table.

I wonder if it's worth adding --strict-whitespace to one or more of the tests, to show that the formatting is correct? What do you think?



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2482
+  size_t Size = 0;
+  for (; Size < Table.size();)
+    if (Table[Size++].getTag() == DT_NULL)
----------------
Could this just be a `while` loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62256/new/

https://reviews.llvm.org/D62256