[PATCH] D61887: [SelectionDAG] computeKnownBits - support constant pool values from target

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Do we get any changes with only the computeKnownBits part of the patch (ie, without the demanded bits part of the patch)?

It seems ok, but I'm wondering if we can reduce risk and the test diffs by splitting those changes up.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2892
+      if ((NumElts * BitWidth) == CstTy->getPrimitiveSizeInBits()) {
+        // If its a vector splat, then we can (quickly) reuse the scalar path.
+        // NOTE: We assume all elements match and none are UNDEF.
----------------
its -> it's (or 'it is')


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61887/new/

https://reviews.llvm.org/D61887