[PATCH] D62154: [cmake] Revert part of r360991 "[Analysis] Only run plugins tests if plugins are actually enabled" that unilaterally disabled plugins

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 22:58:33 PDT 2019


phosek added a comment.

With this change, we're seeing failing tests in Clang:

  error: 'error' diagnostics seen but not expected:
    (frontend): unable to load plugin './lib/SampleAnalyzerPlugin.so': './lib/SampleAnalyzerPlugin.so: undefined symbol: _ZN4llvm14FoldingSetBase6anchorEv'

I have a slightly larger patch that seems to address that and it also contains this one but I'm not sure if it's the right approach.

If we're going to land this change, then I'd argue for reverting D59464 <https://reviews.llvm.org/D59464> as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62154/new/

https://reviews.llvm.org/D62154





More information about the llvm-commits mailing list