[PATCH] D62154: [cmake] Revert part of r360991 "[Analysis] Only run plugins tests if plugins are actually enabled" that unilaterally disabled plugins

[Don Hinton via Phabricator via llvm-commits]

hintonda created this revision.
hintonda added reviewers: phosek, beanz.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

This change makes is impossible to build plugins and test
them in the common case when doing a normal build and
BUILD_SHARED_LIBS and LLVM_BUILD_LLVM_DYLIB are both OFF, e.g., the
buildbots.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62154

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -920,10 +920,14 @@
 
 # Plugin support
 # FIXME: Make this configurable.
-if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
-  set(LLVM_ENABLE_PLUGINS ON)
+if(WIN32 OR CYGWIN)
+  if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
+    set(LLVM_ENABLE_PLUGINS ON)
+  else()
+    set(LLVM_ENABLE_PLUGINS OFF)
+  endif()
 else()
-  set(LLVM_ENABLE_PLUGINS OFF)
+  set(LLVM_ENABLE_PLUGINS ON)
 endif()
 
 # By default we should enable LLVM_ENABLE_IDE only for multi-configuration


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62154.200324.patch
Type: text/x-patch
Size: 684 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190520/a8c762b9/attachment.bin>