[PATCH] D61996: [llvm-objdump]Improve testing of some switches #2
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 20 07:53:48 PDT 2019
jhenderson marked an inline comment as done.
jhenderson added inline comments.
================
Comment at: test/tools/llvm-objdump/X86/source-interleave-invalid-source.test:5
+# RUN: sed -e "s,SRC_COMPDIR,%/p/Inputs,g" %p/Inputs/source-interleave.ll > %t.ll
+# RUN: sed -e "s,line: 7,line: 9999,g" %t.ll > %t2.ll
+
----------------
grimar wrote:
> May be silly question, but what if it is lower? I.e. `s,line: 7,line: -1,g`?
> Does it makes sence to test it?
I don't think so. That sounds like it's testing llc's handling of weird looking data. I'll experiment though to see what it actually ends up as.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61996/new/
https://reviews.llvm.org/D61996
More information about the llvm-commits
mailing list