[PATCH] D61996: [llvm-objdump]Improve testing of some switches #2

Mon May 20 06:59:16 PDT 2019

grimar added a comment.

I do not feel I am right person to accept that, would be nice to have someone else to take a look.
But I read carefully all the test cases and what is going on looks reasonable to me, so I think it is correct.
Minor question is inlined.

================
Comment at: test/tools/llvm-objdump/X86/source-interleave-invalid-source.test:5
+# RUN: sed -e "s,SRC_COMPDIR,%/p/Inputs,g" %p/Inputs/source-interleave.ll > %t.ll
+# RUN: sed -e "s,line: 7,line: 9999,g" %t.ll > %t2.ll
+
----------------
May be silly question, but what if it is lower? I.e. `s,line: 7,line: -1,g`?
Does it makes sence to test it?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61996/new/

https://reviews.llvm.org/D61996