[PATCH] D62107: [ELF] Copy IsPreemptible in replaceSymbol()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 19 19:05:41 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL361122: [ELF] Copy IsPreemptible in replaceSymbol() (authored by MaskRay, committed by ).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62107/new/

https://reviews.llvm.org/D62107

Files:
  lld/trunk/ELF/Symbols.h
  lld/trunk/test/ELF/dynamic-list-preempt-replace-symbol.s


Index: lld/trunk/test/ELF/dynamic-list-preempt-replace-symbol.s
===================================================================
--- lld/trunk/test/ELF/dynamic-list-preempt-replace-symbol.s
+++ lld/trunk/test/ELF/dynamic-list-preempt-replace-symbol.s
@@ -0,0 +1,14 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
+# RUN: echo '{ common; };' > %t.list
+# RUN: ld.lld --dynamic-list %t.list -shared %t.o -o %t.so
+
+# RUN: llvm-readobj -r %t.so | FileCheck %s
+
+# CHECK: R_X86_64_GLOB_DAT common 0x0
+
+movq common at gotpcrel(%rip), %rax
+
+.type common, at object
+.comm common,4,4
Index: lld/trunk/ELF/Symbols.h
===================================================================
--- lld/trunk/ELF/Symbols.h
+++ lld/trunk/ELF/Symbols.h
@@ -473,6 +473,7 @@
   Sym->ExportDynamic = Old.ExportDynamic;
   Sym->CanInline = Old.CanInline;
   Sym->Traced = Old.Traced;
+  Sym->IsPreemptible = Old.IsPreemptible;
   Sym->ScriptDefined = Old.ScriptDefined;
 
   // Print out a log message if --trace-symbol was specified.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62107.200195.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190520/d51ac69e/attachment.bin>


More information about the llvm-commits mailing list