[PATCH] D62108: [AArch64] Handle lowering lround on windows, where long is 32 bit

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: zatrazz, efriedma, rnk.
Herald added subscribers: kristof.beyls, javed.absar.
Herald added a project: LLVM.

Currently, building code with lround for windows with `-fno-math-errno` yields this error:

fatal error: error in backend: Cannot select: t2: i32 = lround ConstantFP:f32<1.000000e+02>

  t1: f32 = ConstantFP<1.000000e+02>


Repository:
  rL LLVM

https://reviews.llvm.org/D62108

Files:
  lib/Target/AArch64/AArch64InstrInfo.td
  test/CodeGen/AArch64/lround-conv-win.ll


Index: test/CodeGen/AArch64/lround-conv-win.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AArch64/lround-conv-win.ll
@@ -0,0 +1,44 @@
+; RUN: llc < %s -mtriple=aarch64-windows -mattr=+neon | FileCheck %s
+
+; CHECK-LABEL: testmsxs:
+; CHECK:       fcvtas  w8, s0
+; CHECK-NEXT:  sxtw    x0, w8
+; CHECK-NEXT:  ret
+define i64 @testmsxs(float %x) {
+entry:
+  %0 = tail call i32 @llvm.lround.i32.f32(float %x)
+  %conv = sext i32 %0 to i64
+  ret i64 %conv
+}
+
+; CHECK-LABEL: testmsws:
+; CHECK:       fcvtas  w0, s0
+; CHECK-NEXT:  ret
+define i32 @testmsws(float %x) {
+entry:
+  %0 = tail call i32 @llvm.lround.i32.f32(float %x)
+  ret i32 %0
+}
+
+; CHECK-LABEL: testmsxd:
+; CHECK:       fcvtas  w8, d0
+; CHECK-NEXT:  sxtw    x0, w8
+; CHECK-NEXT:  ret
+define i64 @testmsxd(double %x) {
+entry:
+  %0 = tail call i32 @llvm.lround.i32.f64(double %x)
+  %conv = sext i32 %0 to i64
+  ret i64 %conv
+}
+
+; CHECK-LABEL: testmswd:
+; CHECK:       fcvtas  w0, d0
+; CHECK-NEXT:  ret
+define i32 @testmswd(double %x) {
+entry:
+  %0 = tail call i32 @llvm.lround.i32.f64(double %x)
+  ret i32 %0
+}
+
+declare i32 @llvm.lround.i32.f32(float) nounwind readnone
+declare i32 @llvm.lround.i32.f64(double) nounwind readnone
Index: lib/Target/AArch64/AArch64InstrInfo.td
===================================================================
--- lib/Target/AArch64/AArch64InstrInfo.td
+++ lib/Target/AArch64/AArch64InstrInfo.td
@@ -3083,6 +3083,10 @@
 defm : FPToIntegerPats<fp_to_sint, fround, "FCVTAS">;
 defm : FPToIntegerPats<fp_to_uint, fround, "FCVTAU">;
 
+def : Pat<(i32 (lround f32:$Rn)),
+          (!cast<Instruction>(FCVTASUWSr) f32:$Rn)>;
+def : Pat<(i32 (lround f64:$Rn)),
+          (!cast<Instruction>(FCVTASUWDr) f64:$Rn)>;
 def : Pat<(i64 (lround f32:$Rn)),
           (!cast<Instruction>(FCVTASUXSr) f32:$Rn)>;
 def : Pat<(i64 (lround f64:$Rn)),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62108.200184.patch
Type: text/x-patch
Size: 1914 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190519/c49631c3/attachment.bin>