[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:455
+    const MachineInstr *CurrDebugInstr = &VarLocIDs[ID].MI;
+    auto DebugInstr = std::find_if(DebugEntryVals.begin(), DebugEntryVals.end(),
+                            [&CurrDebugInstr](MachineInstr *MII) {
----------------
This is going into (low) n^2 territory here. Should we make DebugEntryVals a SmallPtrSet to avoid catastrophic behavior for functions with many arguments?


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:950
+  SmallVector<MachineInstr *, 8> DebugEntryVals;
+  auto IsNewParameter = [&DebugEntryVals](const MachineInstr &MI) -> bool {
+    return !std::any_of(DebugEntryVals.begin(), DebugEntryVals.begin(),
----------------
What does "New" mean here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042